Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: jest tests #76

Merged
merged 1 commit into from
Jun 12, 2021
Merged

fix: jest tests #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/config/generate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ ConfigGenerateCommand.flags = {
description: 'Server port to listen on',
default: 3000,
}),
secretKey: flags.string({
secretkey: flags.string({
description: 'Secret key for password validation (default auto generate random string)',
}),

Expand Down
4 changes: 2 additions & 2 deletions src/utils/ask-questions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ const askQuestions = async () => {
},
{
type: 'input',
name: 'server.secretKey',
name: 'server.secretkey',
message: 'Secret key for password validation (default to auto-generate random secret key)',
filter: answer => {
// Return auto generated secretKey on empty answer
// Return auto generated secretkey on empty answer
if (answer === '') return generatePassword
return answer
},
Expand Down
4 changes: 2 additions & 2 deletions tests/command/config-generate.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('config:generate command', () => {
})

it('with flags', async () => {
const command = await runCommand(['config:generate', '--port=80', '--secretKey=mySecretKey', '--dbhost=postgres-db.logchimp.codecarrot.net', '--dbuser=pg_db_user', '--dbpass=myDatabasePassword', '--dbname=pg_db', '--dbport=51000', '--no-dbssl', '--mailservice=awesomeMailService', '--mailuser=mail_user', '--mailpass=myMailPassword', '--mailhost=mail-server.logchimp.codecarrot.net', '--mailport=587'])
const command = await runCommand(['config:generate', '--port=80', '--secretkey=mySecretKey', '--dbhost=postgres-db.logchimp.codecarrot.net', '--dbuser=pg_db_user', '--dbpass=myDatabasePassword', '--dbname=pg_db', '--dbport=51000', '--no-dbssl', '--mailservice=awesomeMailService', '--mailuser=mail_user', '--mailpass=myMailPassword', '--mailhost=mail-server.logchimp.codecarrot.net', '--mailport=587'])

expect(command.stdout).toBe('LogChimp configuration file succesfully created.')

Expand All @@ -44,7 +44,7 @@ describe('config:generate command', () => {
// server
expect(config.local).toBe(false)
expect(config.port).toBe(80)
expect(config.secretKey).toBe('mySecretKey')
expect(config.secretkey).toBe('mySecretKey')
// database
expect(config.database.host).toBe('postgres-db.logchimp.codecarrot.net')
expect(config.database.port).toBe(51000)
Expand Down