Always build source jar #1037
Merged
Always build source jar #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a regression introduced when building the source jar during releases when the maven-release-plugin was upgraded. To simplify things, and avoid that in the future, I changed the build to alwas package the source jar. Fixes #1036
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
============================================
+ Coverage 71.78% 71.82% +0.03%
- Complexity 1417 1429 +12
============================================
Files 177 178 +1
Lines 5178 5199 +21
Branches 534 539 +5
============================================
+ Hits 3717 3734 +17
+ Misses 1197 1195 -2
- Partials 264 270 +6 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression introduced in 8.0 when building the source jar during releases when the maven-release-plugin was upgraded.
To simplify things, and avoid that in the future, I changed the build to always package the source jar.
Fixes #1036