Refactor: unify event updates to happen in one place #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on `RSpec::Expectations::ExpectationNotMetError`
kares
changed the title
robbavey
reviewed
Jun 9, 2021
spec/inputs/file_read_spec.rb
Outdated
| @@ -363,7 +363,9 @@ def wait_for_start_processing(run_thread, timeout: 1.0) | |||
| end | |||
| end | |||
|
|
|||
| def wait_for_file_removal(path, timeout: 3 * interval) | |||
| wait(timeout).for { File.exist?(path) }.to be_falsey | |||
| def wait_for_file_removal(path, timeout: interval) | |||
There was a problem hiding this comment.
I don't see the timeout parameter used anywhere, can we remove it?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple refactoring to have
event.setin one place for easy understanding.There's also 2 minor changes to make CI more stable - properly re-trying on rspec expectation failure