Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix saving pipeline state using record_last_run setting #374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

palin
Copy link

@palin palin commented Feb 19, 2020

This fixes the issue with clean run: #373

The state should not be written if the record_last_run setting is false.

@bulletproof-coding
Copy link

bulletproof-coding commented Apr 8, 2024

logstash-plugins/logstash-integration-jdbc#121 (comment)

clean_run => true
record_last_run => true
last_run_metadata_path => "/..."

seems to be the solution and that is why this was not merged.

@s137
Copy link

s137 commented Apr 8, 2024

Why is this not merged? The issue persists to this day... We applied the patch manually and it works...

I don't think this patch will be merged here, because the plugin is now part of the jdbc-integration-plugin in this repository, where I created the same issue, when I stumbled upon it, but the solution is of course the same regardless.

Honestly I just made another jdbc-input which uses a separate query without :sql_last_value to work around it. It's not ideal, but it does the job.

@bulletproof-coding
Copy link

bulletproof-coding commented Apr 8, 2024

@s137 commented also there. See my previous message from here for the link.

Update logstash-plugins/logstash-integration-jdbc#121 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants