Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ECS compatibility table #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fgierlinger
Copy link

Release notes

Docs: Fix ECS compatibility table rendering

What does this PR do?

The table definition contains 4 fields but the actual table only consists of 3 fields (ecs disabled, ecs v1/v8, description). Because of this mismatch of the table columns, the resulting rendered table was wrong.

image

Why is it important/What is the impact to the user?

Better understanding of the changes introduces by ECS v8 while reading the documentation.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

image

Logs

@fgierlinger fgierlinger closed this by deleting the head repository Oct 2, 2023
@fgierlinger fgierlinger reopened this Oct 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant