Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for client_dns_lookup setting #28

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

ajoliveira
Copy link
Contributor

  • Add client_dns_lookup setting to both input and output plugins
  • Update documentation to reflect setting options

- Add `client_dns_lookup` setting to both input and output plugins
- Update documentation to reflect setting options
@kares
Copy link
Contributor

kares commented Apr 6, 2020

Thanks Angelo, looking good!

Would consider to makes the supported values enumerated, just to catch typos earlier, wdyt?
(:validate => ["default", "use_all_dns_ips", "resolve_canonical_bootstrap_servers_only"])

Also if you could please bump the version to 10.2.0 and add a CHANGELOG entry for the target version, and link this PR there, it would be could to release right after its merged.

@ajoliveira
Copy link
Contributor Author

Thanks for noting that. Let me know if anything else is required.

@roaksoax
Copy link

@ajoliveira It seems this branch has conflicts. Any chance you could address those ?

@roaksoax
Copy link

@kares Since you are the original reviewer, could you please take a look again?

Copy link
Contributor

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kares kares merged commit 8cddfb8 into logstash-plugins:master Jun 18, 2020
kares added a commit that referenced this pull request Jun 18, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants