-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Docs: reflect clients update (since 10.6.0) #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds cleanly and renders as expected. I left a comment inline for your consideration, but I trust your judgement on the resolution. LGTM
@@ -2,8 +2,8 @@ | |||
:plugin: kafka | |||
:type: input | |||
:default_codec: plain | |||
:kafka_client: 2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating these vars. I'm happy to seem them being used. :-)
We used version 2.5.1
in the integration doc and version 2.5
for both input and output docs. We should be consistent. Perhaps we should have your version checking in place before we commit to maintaining more granular versions (2.5.1 instead of 2.5).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here is we need to have the precise version somewhere (to be able to know bug fixes etc).
For the input/output specific documentation it seemed okay to only have the minor version compatibility (the Kafka docs linked only uses minor version paths such as /25/...
) but I am fine changing that if you prefer so.
I do have the version checking PR as a follow-up on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with merging as is, and waiting for your version checking PR to go more granular on version info in input and output. I have more changes I need to make anyway, so I can make the fixes after version checking is merged. Thanks!
c0b6bef#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R67