Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

support giving up on failed individual bulk requests after a number of retries #909

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thethumbler
Copy link

This commit adds a new config parameter retry_max_failures that controls the maximum number of retries that should be attempted for failed individual bulk requests (0 means infinity).

Resolves #795 #806

@ThaSami
Copy link

ThaSami commented Apr 5, 2021

any updates on this?

@andsel
Copy link
Contributor

andsel commented Sep 30, 2021

Thanks @thethumbler for your contribution.
This proposal misses some test for the behavior it introduces.

From a user perspective the drop of events once it reaches the retry_max_failures is not optimal, maybe considering the insertion on DLQ could be an viable path.

@andsel
Copy link
Contributor

andsel commented Oct 13, 2021

The feature we could implement is to drop the events when retry_max_failures is reached, but if the option is configured a WARN log should be present to make the user aware of the event drops, without pushing to the DLQ.
This feature should be well documented with a warning box that when enabled it could generate message loss. Maybe a specific metric could also be used to track the number of dropped events due to retry_max_failure overtake.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

infinite retries when encountering IllegalArgumentException
4 participants