Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Display issue: Depedencies formatting #369

Closed
euantorano opened this issue Oct 1, 2019 · 6 comments
Closed

Display issue: Depedencies formatting #369

euantorano opened this issue Oct 1, 2019 · 6 comments

Comments

@euantorano
Copy link
Contributor

Describe the bug

The dependencies list when viewing a package has a weird formatitng issue - the version constraint starts with a [ but closes with a ) and there is a trailing comma. It's probably best to just see the below screenshot.

Screenshots

Capture

@euantorano
Copy link
Contributor Author

euantorano commented Oct 1, 2019

I've just double checked the database, and the data is actually stored in this format:

| Id | VersionRange | TargetFramework | PackageKey |
| --- | --- |
| NETStandard.Library | [1.6.1, ) | netstandard1.4 | NULL |

It appears this is the string representation of a VersionRange. In my opinion, surfacing this to the user is a little nasty. I'm not sure how the official nuGet site does it, but I'll have a look.

@loic-sharma
Copy link
Owner

Thanks for opening this! NuGet.org cleans up the text and makes the dependency a link:

image

I think I'll follow that model too. Let me know if you have more suggestions, I plan to invest in the UI as part of #237

@euantorano
Copy link
Contributor Author

euantorano commented Oct 2, 2019 via email

@yzhoholiev
Copy link

@euantorano actually, t's a valid Nuget Package Versioning format https://docs.microsoft.com/en-us/nuget/concepts/package-versioning

@euantorano
Copy link
Contributor Author

@yzhoholiev Yeah I realized that in #369 (comment) - it's just that displaying that raw string isn't the best user experience in my opinion.

loic-sharma added a commit that referenced this issue Oct 13, 2019
@loic-sharma
Copy link
Owner

This is fixed in #375. If you'd like, you can build the latest code or use the latest Docker image (I will update the NuGet packages and GitHub release when v0.2.0-preview2 is shipped). Please let me know if you have any other suggestions or find any other bugs!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants