-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Display issue: Depedencies formatting #369
Comments
I've just double checked the database, and the data is actually stored in this format: | Id | VersionRange | TargetFramework | PackageKey | It appears this is the string representation of a |
Thanks for opening this! NuGet.org cleans up the text and makes the dependency a link: I think I'll follow that model too. Let me know if you have more suggestions, I plan to invest in the UI as part of #237 |
Yeah, that looks good to me. Might as well keep it similar to nuget.org to ease the transition for people.
…On Wed, 2 Oct 2019, at 01:35, Loïc Sharma wrote:
Thanks for opening this! NuGet.org cleans up the text and makes the dependency a link:
image <https://user-images.githubusercontent.com/737941/66009881-50d3b580-e471-11e9-9ab5-49e9f7a6942f.png>
I think I'll follow that model too. Let me know if you have more suggestions, I plan to invest in the UI as part of #237 <#237>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#369?email_source=notifications&email_token=AAFW24K5IC32O6GS6LKAFTLQMPUGBA5CNFSM4I4NDWXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADFMCY#issuecomment-537286155>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFW24LJ74MQNECXNOASZ4TQMPUGBANCNFSM4I4NDWXA>.
|
@euantorano actually, t's a valid Nuget Package Versioning format https://docs.microsoft.com/en-us/nuget/concepts/package-versioning |
@yzhoholiev Yeah I realized that in #369 (comment) - it's just that displaying that raw string isn't the best user experience in my opinion. |
This is fixed in #375. If you'd like, you can build the latest code or use the latest Docker image (I will update the NuGet packages and GitHub release when v0.2.0-preview2 is shipped). Please let me know if you have any other suggestions or find any other bugs! |
Describe the bug
The dependencies list when viewing a package has a weird formatitng issue - the version constraint starts with a
[
but closes with a)
and there is a trailing comma. It's probably best to just see the below screenshot.Screenshots
The text was updated successfully, but these errors were encountered: