This repository has been archived by the owner on Jan 5, 2021. It is now read-only.
fix Users.Get(int[] ids, ...), add "Get Users" to console scene #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicteixeira
approved these changes
Oct 20, 2017
Assets/Tests/Console/ConsoleTest.cs
Outdated
| @@ -62,6 +64,18 @@ public void SignOut() | |||
| AddConsoleLine(string.Format("Sign Out {0}.", isSignedIn ? "Successful" : "Failed")); | |||
| } | |||
|
|
|||
| public void GetUsersById() { | |||
| var ids = ParseIds(userIdsField.text); | |||
There was a problem hiding this comment.
The initial goal of the console was to give people an easy way in but I've never released it officially (at least not outside of the repo), but to keep things consistent, it would be great to have AddConsoleLine("Get Users by ID. Click to see source.")
| @@ -343,6 +352,8 @@ void Start() | |||
| userNameField.text = settings.user; | |||
| userTokenField.text = settings.token; | |||
| } | |||
| userIdsField.onValidateInput += ValidateIdList; | |||
| { | ||
| var parameters = new Dictionary<string, string>(); | ||
| parameters.Add(Constants.API_USERS_FETCH, string.Join(",", ids.Select(id => id.ToString()).ToArray())); |
There was a problem hiding this comment.
Err that was a really silly mistake. Nice work.
| @@ -119,11 +93,25 @@ public static void Delete(string key, bool global, Action<bool> callback = null) | |||
| /// <summary> | |||
| /// Gets the list of available keys in the DataStore. | |||
| /// </summary> | |||
| /// <param name="global">A boolean indicating whether the keys are global (<c>true<c/>) or private to the user (<c>false<c/>).</param> | |||
| /// <param name="global">A boolean indicating whether the keys are global (<c>true</c>) or private to the user (<c>false</c>).</param> | |||
| /// <param name="callback">A callback function accepting a single parameter, a list of key names.</param> | |||
| public static void GetKeys(bool global, Action<string[]> callback) | |||
There was a problem hiding this comment.
Nice one on making it backward compatible 👍
|
yeah sorry, the pull request was only for the "get users"-fix. I forgot to switch to a dedicated branch. I will update the PR today or tomorrow so we can merge it soon. |
|
PR ready to merge |
|
Well done! Thanks for your help. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #79 and also adds a "Get Users" function to the Console scene.