Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update minimum Ruby to 3.1 #433

Merged

Conversation

SalvatoreT
Copy link
Contributor

Update the dependencies to the latest versions.

Ruby 3.2 dropped support for File.exists? and only has the singular File.exist?.


📝 Checklist

  • Commit messages provide context (why not just what, some tips here).
  • If relevant, mention GitHub issue number above and include in a commit message.
  • Latest code from master merged.
  • New behaviour has test coverage.
  • Avoid duplicating code.
  • No commented out code.
  • Avoid comments for your code, write code that explains itself.
  • Changes are simple, useful, clear and brief.

Update the dependencies to the latest versions.

Ruby 3.2 dropped support for `File.exists?` and only has the singular
`File.exist?`.
Copy link
Member

@matthutchinson matthutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for this, looks great, will merge and prep a new release shortly

@matthutchinson matthutchinson merged commit d541157 into lolcommits:main Sep 14, 2024
@matthutchinson
Copy link
Member

Sorry for the huge delay, I'm now working on some cleanups to this gem, to bring it into the modern Ruby age, this PR is a great first step! 🙇‍♂️

@SalvatoreT SalvatoreT deleted the salvatoret/support-ruby-3.1 branch September 16, 2024 20:11
@SalvatoreT
Copy link
Contributor Author

Yay! I love this tool so much.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants