Fix unicode parsing #139
Merged
Fix unicode parsing #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasChr
force-pushed
the
fix_unicode_parsing
branch
from
d48bc38 to
a63b5a0
Compare
lolo101
reviewed
Sep 26, 2022
MSGViewer/src/main/javacc/net/sourceforge/MSGViewer/rtfparser/RTFParser.jj
Outdated
Show resolved
Hide resolved
|
The mail did not go through. I sent it again. |
ThomasChr
force-pushed
the
fix_unicode_parsing
branch
3 times, most recently
from
fa9c7bd to
7809917
Compare
ThomasChr
force-pushed
the
fix_unicode_parsing
branch
from
7809917 to
ef44f62
Compare
|
And that did the trick! |
|
Very well! Thank you very much for the very details report, the fix, and the test 😉 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #136
(Too) many explanations in the issue
I'm not quite sure if this is the right way to do it, but I think it should be correct.
I have two testmails (can't publish them openly) which are now working.
They have both kinds of RTF-Unicode Strings in them:
No. 1:
(C_UNICODE_STRING)
No 2:
(C_UNICODE_ESC_STRING)