Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

💄 Pull version from installation metadata #172

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

mjpieters
Copy link
Collaborator

The version string in the __init__ module is needed to support towncrier, but that does mean there are now two locations for the project version: pyproject.toml and the __init__.py file. Use importlib.metadata to pull the version from the installation metadata.

@mjpieters mjpieters added this to the Version 1.0.0a1 milestone May 17, 2023
@mjpieters mjpieters enabled auto-merge (squash) May 17, 2023 17:06
@github-actions github-actions bot added the auto-merge Auto-merge enabled label May 17, 2023
The version string in the `__init__` module is needed to support
towncrier, but that does mean there are now two locations for the
project version: pyproject.toml and the `__init__.py` file. Use
`importlib.metadata` to pull the version from the installation metadata.
@mjpieters mjpieters force-pushed the version_single_source branch from ca266fe to 32ef0a4 Compare May 17, 2023 17:07
@github-actions github-actions bot added the changelog-provided PR includes a towncrier changelog entry label May 17, 2023
@mjpieters mjpieters merged commit fbdaa62 into main May 17, 2023
@mjpieters mjpieters deleted the version_single_source branch May 17, 2023 17:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
auto-merge Auto-merge enabled changelog-provided PR includes a towncrier changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant