Renaming BackupError to Error in Manager #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code changes modify the name `backupError` to `error`
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
Update github.com/container-storage-interface/spec to v1.1.0 Remove github.com/kubernetes-csi/drivers Add github.com/kubernetes-csi/csi-lib-utils v0.6.1 Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
1. Since the CSI version is upgrade to v1.1.0, there are serval new service functions introduced (but not implemented). 2. After removing the dependency csi-common, we need to take care of the server definition and gRPC server launch. Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
In previous implementation, the provisioner name is different from the driver name. But the new provisioner will directly use the driver name as its provisioner name. Hence we need an uniform driver name for all CSI components. https://github.com/kubernetes-csi/external-provisioner/tree/v1.4.0#deprecated-arguments Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
…amework See https://kubernetes-csi.github.io/docs/csi-driver-object.html for details. Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
…tation Now the provisioner won't wait for Detach (ControllerUnpublishVolume()) complete before invoking DeleteVolume. Then Detach will get stuck in the NOT_FOUND error since there is no way to verify the volume before detaching. For the details, See container-storage-interface/spec#382 And the spec doc has removed NOT_FOUND error for ControllerUnpublishVolume(): https://github.com/container-storage-interface/spec/blob/release-1.2/spec.md#controllerunpublishvolume Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
Since we modified our CSI driver name to `driver.longhorn.io` Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
1. The new external CSI provisioner will use driver name as its provisioner name. Previously, the provisioner name is different from driver name, which is `rancher.io/longhorn` and does not follow the driver naming schema. Hence we cannot deploy a compatible provisioner and a related CSI driver with old provisioner name to handle the existing volumes. 2. The external CSI provisioner uses the annotations of PVC/PV to find the matching CSI driver. Hence we can updating the annotations for Longhorn related PVC/PV so that the new provisioner is able to verify and handle the existing volumes. Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 5, 2019
The existing running volumes are still using the old driver name. We can deploy a compatible CSI driver and an attacher with the old driver name to handle attach and detach for those volumes. Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
Update github.com/container-storage-interface/spec to v1.1.0 Remove github.com/kubernetes-csi/drivers Add github.com/kubernetes-csi/csi-lib-utils v0.6.1 Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
1. Since the CSI version is upgrade to v1.1.0, there are serval new service functions introduced (but not implemented). 2. After removing the dependency csi-common, we need to take care of the server definition and gRPC server launch. Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
In previous implementation, the provisioner name is different from the driver name. But the new provisioner will directly use the driver name as its provisioner name. Hence we need an uniform driver name for all CSI components. https://github.com/kubernetes-csi/external-provisioner/tree/v1.4.0#deprecated-arguments Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
…amework See https://kubernetes-csi.github.io/docs/csi-driver-object.html for details. Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
…tation Now the provisioner won't wait for Detach (ControllerUnpublishVolume()) complete before invoking DeleteVolume. Then Detach will get stuck in the NOT_FOUND error since there is no way to verify the volume before detaching. For the details, See container-storage-interface/spec#382 And the spec doc has removed NOT_FOUND error for ControllerUnpublishVolume(): https://github.com/container-storage-interface/spec/blob/release-1.2/spec.md#controllerunpublishvolume Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
Since we modified our CSI driver name to `driver.longhorn.io` Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
1. The new external CSI provisioner will use driver name as its provisioner name. Previously, the provisioner name is different from driver name, which is `rancher.io/longhorn` and does not follow the driver naming schema. Hence we cannot deploy a compatible provisioner and a related CSI driver with old provisioner name to handle the existing volumes. 2. The external CSI provisioner uses the annotations of PVC/PV to find the matching CSI driver. Hence we can updating the annotations for Longhorn related PVC/PV so that the new provisioner is able to verify and handle the existing volumes. Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu
pushed a commit
to shuo-wu/longhorn-manager
that referenced
this pull request
Nov 8, 2019
The existing running volumes are still using the old driver name. We can deploy a compatible CSI driver and an attacher with the old driver name to handle attach and detach for those volumes. Longhorn longhorn#347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
Update github.com/container-storage-interface/spec to v1.1.0 Remove github.com/kubernetes-csi/drivers Add github.com/kubernetes-csi/csi-lib-utils v0.6.1 Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
1. Since the CSI version is upgrade to v1.1.0, there are serval new service functions introduced (but not implemented). 2. After removing the dependency csi-common, we need to take care of the server definition and gRPC server launch. Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
In previous implementation, the provisioner name is different from the driver name. But the new provisioner will directly use the driver name as its provisioner name. Hence we need an uniform driver name for all CSI components. https://github.com/kubernetes-csi/external-provisioner/tree/v1.4.0#deprecated-arguments Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
…amework See https://kubernetes-csi.github.io/docs/csi-driver-object.html for details. Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
…tation Now the provisioner won't wait for Detach (ControllerUnpublishVolume()) complete before invoking DeleteVolume. Then Detach will get stuck in the NOT_FOUND error since there is no way to verify the volume before detaching. For the details, See container-storage-interface/spec#382 And the spec doc has removed NOT_FOUND error for ControllerUnpublishVolume(): https://github.com/container-storage-interface/spec/blob/release-1.2/spec.md#controllerunpublishvolume Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
Since we modified our CSI driver name to `driver.longhorn.io` Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
1. The new external CSI provisioner will use driver name as its provisioner name. Previously, the provisioner name is different from driver name, which is `rancher.io/longhorn` and does not follow the driver naming schema. Hence we cannot deploy a compatible provisioner and a related CSI driver with old provisioner name to handle the existing volumes. 2. The external CSI provisioner uses the annotations of PVC/PV to find the matching CSI driver. Hence we can updating the annotations for Longhorn related PVC/PV so that the new provisioner is able to verify and handle the existing volumes. Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
yasker
pushed a commit
that referenced
this pull request
Nov 8, 2019
The existing running volumes are still using the old driver name. We can deploy a compatible CSI driver and an attacher with the old driver name to handle attach and detach for those volumes. Longhorn #347 Signed-off-by: Shuo Wu <shuo@rancher.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code changes modify the name
backupErrortoerror