Add support to protocol to be 'monogodb+srv' #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
requested review from
b-admike,
dhmlau,
jannyHou,
shimks and
virkt25
as code owners
raymondfeng
force-pushed
the
allow-mongodb-srv-protocol
branch
from
e8a95da to
cf2bde0
Compare
virkt25
approved these changes
Sep 7, 2018
lib/mongodb.js
Outdated
| @@ -49,13 +49,17 @@ exports.generateMongoDBURL = generateMongoDBURL; | |||
| * Generate the mongodb URL from the options | |||
| */ | |||
| function generateMongoDBURL(options) { | |||
| // See https://docs.mongodb.com/manual/reference/connection-string/#dns-seedlist-connection-format | |||
| // It can be `mongodb+srv` now. | |||
| var protocol = options.protocol || 'mongodb'; | |||
There was a problem hiding this comment.
For consistency can we make this options.protocol = options.protocol || 'mongodb'
raymondfeng
force-pushed
the
allow-mongodb-srv-protocol
branch
from
cf2bde0 to
695bb20
Compare
virkt25
reviewed
Sep 12, 2018
| "eslint": "^5.1.0", | ||
| "eslint-config-loopback": "^10.0.0", | ||
| "loopback-datasource-juggler": "^3.0.0", | ||
| "memwatch-next": "^0.3.0", |
Makefile
Outdated
| @@ -19,6 +19,7 @@ b benchmark benchmarks: | |||
|
|
|||
| .PHONY: l ld leak leak-detection | |||
| l ld leak leak-detection: | |||
| npm i memwatch-next --no-save | |||
There was a problem hiding this comment.
Can we use @airbnb/node-memwatch instead here. It's compatible with Node 8/10. And then can you please update the Leak Detection section of the readme explaining that it only works on Node 8/10.
raymondfeng
force-pushed
the
allow-mongodb-srv-protocol
branch
from
ad796be to
46720c5
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.mongodb.com/manual/reference/connection-string/
Description
We don't have a way to specify
mongodb+srv://. This PR makes it configurable.Related issues
Checklist
guide