Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(rest): mount CORS as a regular middleware #1338

Merged
merged 1 commit into from
May 18, 2018
Merged

refactor(rest): mount CORS as a regular middleware #1338

merged 1 commit into from
May 18, 2018

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented May 17, 2018

Clean up the RestServer implementation by moving CORS out of _handleHttpRequest() and mounting it as a regular Express middleware instead.

This is a follow-up for #1326 as part of #1038.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@bajtos bajtos added the REST Issues related to @loopback/rest package and REST transport in general label May 17, 2018
@bajtos bajtos added this to the May Milestone milestone May 17, 2018
@bajtos bajtos self-assigned this May 17, 2018
@bajtos bajtos requested a review from raymondfeng May 17, 2018 09:03
@bajtos bajtos mentioned this pull request May 17, 2018
Closed
@dhmlau dhmlau mentioned this pull request May 17, 2018
Closed
23 tasks
@bajtos
refactor(rest): mount CORS as a regular middleware
6b3e975 
Clean up the RestServer implementation by moving CORS out of
_handleHttpRequest() and mounting it as a regular Express middleware
instead.
@bajtos bajtos merged commit 0411811 into master May 18, 2018
@bajtos bajtos deleted the refactor/cors branch May 18, 2018 07:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@virkt25 virkt25 virkt25 approved these changes

@jannyHou jannyHou jannyHou approved these changes

@shimks shimks shimks approved these changes

Assignees

@bajtos bajtos

Labels
REST Issues related to @loopback/rest package and REST transport in general
Projects
None yet
Milestone
May Milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bajtos @raymondfeng @virkt25 @jannyHou @shimks