Add Rounded Corners #135
Draft
Add Rounded Corners #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-wils
requested changes
Feb 4, 2025
| </script> | ||
| </lottie-playground> | ||
|
|
||
| Note: it does not affect: |
There was a problem hiding this comment.
I think this won't affect paths if the control points on both of the vertices for a given edge are set? I'm not sure if that is explicit or not, was playing around with different possibilities in AE. There also seems like some edge cases where the corners get sharper?
| @@ -663,3 +663,28 @@ separately, $start$ and $end$ being applied to each shape. | |||
| * When `m` has a value of `2` (Sequential), all the shapes MUST be considered | |||
| as following each other in render order. $start$ and $end$ refer to the whole | |||
| length created by concatenating each shape. | |||
|
|
|||
|
|
|||
| <h3 id="trim-path">Rounded Corners</h3> | |||
There was a problem hiding this comment.
Can we include the rendering algorithm as well? Particularly how it's different from rectangle roundness (see #82)
mbasaglia
reviewed
Feb 5, 2025
Comment on lines
+605
to
+607
| "ix": 6, | ||
| "mn": "ADBE Vector Filter - RC", | ||
| "hd": false |
There was a problem hiding this comment.
I think the example should be cleaned up, removing stuff that is not in the specs or irrelevant
mbasaglia
reviewed
Feb 5, 2025
| }, | ||
| "r": { | ||
| "title": "Roundness", | ||
| "description": "Rounded corner radius", |
There was a problem hiding this comment.
It's not really a radius here, right?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@issue: #119