Added support for pasting text into the terminal #623
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Hi @louislam, one of the GitHub Actions jobs for my pull request hasn't started. Let me know if I need to take any action. |
|
👀 |
|
giving this a bump, @louislam I know you're busy but perhaps adding someone to the project for approving these more basic feature and bug fixes would really help out. |
justwiebe
reviewed
Dec 30, 2024
Comment on lines
+134
to
+140
| this.terminal.textarea.addEventListener("paste", (event) => { | ||
| const textToPaste = event.clipboardData.getData("text").replace(/\n+$/, ""); | ||
| this.cursorPosition += textToPaste.length; | ||
| this.terminalInputBuffer += textToPaste; | ||
| console.debug("Paste text: " + textToPaste); | ||
| this.terminal.write(textToPaste); | ||
| }); |
There was a problem hiding this comment.
It would probably be better to use the xterm addon to this
https://github.com/xtermjs/xterm.js/tree/master/addons/addon-clipboard
|
I would so love to have this. so frustrating not to be able to paste. |
|
HI,
For information I try it from linux ubuntu 24.04 and with chrome and firefox. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md
Tick the checkbox if you understand [x]:
Description
Fixes #613
This pull request adds support for pasting text into the terminal using the mouse right-click context menu and the keyboard shortcut
CTRL + SHIFT + V.Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.