Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat: Add SMTP DKIM settings #1080

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Dec 19, 2021

Description

Closes #1030

This should just work as we just exposed the nodemailer's DKIM settings. I don't have a mailserver setup to test tho.

Type of change

  • User Interface
  • New feature (non-breaking change which adds functionality)
  • Translation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and test it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

cc. @ilogus

@ilogus
Copy link

ilogus commented Dec 19, 2021

Hi @chakflying, I just tested your fork, everything is good on my side ! ✅

Here are some screens :
dkim_test_01
dkim_test_02
dkim_test_03

If you want to test by yourself, and modify the options, contact me by email I could send you smtp credentials and a private key.

Thank you for this feature, in the hope that it will be fully validated !

@chakflying chakflying changed the title Feat: Add SMTP DKIM settings (test needed) Feat: Add SMTP DKIM settings Dec 19, 2021
@andreasbrett
Copy link
Contributor

Awesome! Can't wait to see this in production.

@yeya
Copy link

yeya commented Dec 21, 2021

@ilogus You should not post your private key or any part of it in public

@ilogus
Copy link

ilogus commented Dec 21, 2021

@ilogus You should not post your private key or any part of it in public

Don't worry, this mailbox, the DNS record with the public key and the private key were only used for this test. In order to be able to take a picture of this for you

@louislam louislam merged commit a48176b into louislam:master Dec 22, 2021
@chakflying chakflying deleted the feat/smtp-dkim branch December 23, 2021 02:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DKIM settings for SMTP notifications
5 participants