Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename 2FA/TOTP field ID for password manager filling compatibility #1184

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

khord
Copy link
Contributor

@khord khord commented Jan 13, 2022

Description

It would be nice to update the TOTP Token field's id to something like otp, totp, 2fa, code, two-factor, challenge, token, mfa etc to support password manager filling, such as with 1Password's built in TOTP authenticators.

Some context from a similar issue:
https://1password.community/discussion/comment/544305/#Comment_544305

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

uptime-kuma
image

working example 1
image

working example 2 - bestbuy.com
image

khord added 2 commits January 13, 2022 16:46
since "Token" is used in several places in the 2FA setup screen
src/components/#.vue Outdated Show resolved Hide resolved
@khord khord changed the title Rename 2FA/TOTP field attribute for password manager filling compatibility Rename 2FA/TOTP field ID for password manager filling compatibility Jan 14, 2022
@louislam louislam merged commit c3c4db5 into louislam:master Jan 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants