Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UI/UX: Added no tags found message to tags filter when empty #3676

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

BrandonDR
Copy link
Contributor

@BrandonDR BrandonDR commented Sep 2, 2023

  • I have read and understand the pull request rules.

Description

  • Added a "No tags found." message to the tags filter drop down in MonitorListFilter.vue
    I noticed it appears to do nothing if there are no tags used. I checked the other filters but they will never be empty, so this is only needed for tags.

Type of change

  • Small UX enhancement

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants