-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore:extracted the group monitor to a different monitoring type #4395
base: master
Are you sure you want to change the base?
chore:extracted the group monitor to a different monitoring type #4395
Conversation
Hello, this PR presumably only affects the backend? Wouldn't it make sense to use this grouping for the frontend as well? As the servers in this group are not currently visible there and the entire group is displayed as "down" if a service fails |
The existing grouping functionality (see screenshots) was not changed. It is implemented in the frontend.
Currently, groups are down if This is tracked in different issues and I decided not to include them to make reviewing eazier.
|
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
This PR is part of the migration to monitoring-types.
I migrated the
group
monitor into a different monitoring type.No actual code changes have been made, this is just a code move.
Type of change
Checklist
Screenshots (if any)