-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add gtxmessaging Notification Support #4481
Add gtxmessaging Notification Support #4481
Conversation
Signed-off-by: Christoph Fichtmüller <cf@cfichtmueller.com>
Notification providers do not require a discussion. When adding a notification provider, these things are common in the review:
Footnotes
|
@CommanderStorm thank you for your reply. The PR manual explicitly states that a discussion is needed beforehand, hence my approach. May I suggest to add a small note here? Unless of course I'm the only one who misunderstood 😄 I'll go ahead and implement the provider. I'll create it as a global provider since they offer english API documentation and operate internationally. |
Co-authored-by: Frank Elsinga <frank@elsinga.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the current code.
I have changed some helptexts to be more explicit in what is being asked (f.ex. the part about the TPOA
) and have added the required links.
Thanks for the new notification provider! All changes in this PR are uncontroversial |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
I'd like to add a new notification provider for gtxmessaging. They provide an SMS gateway, so this is about SMS notifications.
@louislam please let me know if this is a feature you would like to have in the project. Cheers.
Type of change
Please delete any options that are not relevant.
Checklist
[ ] My code needed automated testing. I have added them(this is optional task)Screenshots (if any)
Setup
Up / Down / Certificate Expired / Test Notification