Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Add missing FK for monitor-tls-info table #4632

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

The monitor-tls-info table has missing foreign key referencing the monitor table. This leads to orphan tls-info entries when monitors are deleted, which may take up disk space. Adding back the foreign key by modifying the table schema fixes this.

This fix is for 2.0. I think existing mariadb databases will not be affected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@chakflying chakflying added this to the 2.0.0 milestone Mar 29, 2024
@chakflying chakflying added the area:core issues describing changes to the core of uptime kuma label Mar 29, 2024
@louislam louislam merged commit 08f75b0 into louislam:master Mar 31, 2024
17 checks passed
@chakflying chakflying deleted the fix/monitor-tls-info-missing-fk branch April 30, 2024 20:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area:core issues describing changes to the core of uptime kuma
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants