Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show URL for "real-browser" type monitor on details page #4942

Merged
merged 1 commit into from Jul 15, 2024
Merged

Show URL for "real-browser" type monitor on details page #4942

merged 1 commit into from Jul 15, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Currently URL is not displayed for "real-browser" type monitor:
image

Fixes #(issue)

This change will make it appear.

Type of change

Please delete any options that are not relevant.

  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@CommanderStorm CommanderStorm added area:dashboard The main dashboard page where monitors' status are shown type:enhance-existing feature wants to enhance existing monitor pr:needs review this PR needs a review by maintainers or other community members labels Jul 15, 2024
@CommanderStorm
Copy link
Collaborator

LGTM 👍🏻

@CommanderStorm CommanderStorm merged commit 6f1b8b4 into louislam:master Jul 15, 2024
17 checks passed
@CommanderStorm
Copy link
Collaborator

Thanks for the enhancement! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Jul 15, 2024
@ghost ghost deleted the patch-1 branch July 29, 2024 18:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown pr:needs review this PR needs a review by maintainers or other community members type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant