HMILayout via slotchange #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanereetz
commented
Jan 24, 2024
| }); | ||
|
|
||
| if (+templatesIndex < divs.length) { | ||
| divs[templatesIndex].setAttribute('slot', 'content') |
There was a problem hiding this comment.
The crux of this approach: setting this attribute causes this div to be displayed inside <div class="tmplit-main-content">, because that div contains the content slot.
shanereetz
commented
Jan 24, 2024
|
|
||
| <template title="Button 2"> | ||
| <div slot="list" title="Button 1"> |
There was a problem hiding this comment.
There are some downsides to using divs here instead of templates (harder to of select only visible things)
shanereetz
commented
Jan 24, 2024
| {{!-- <h1>Cosntent 3</h1> --}} | ||
| </div> | ||
|
|
||
| <footer slot="footer"> |
There was a problem hiding this comment.
Using footer tag here for readability, and convenience of selection
shanereetz
commented
Jan 24, 2024
| navBarLoc ==='right' ? 'tmplit-navBar-container-right tmplit-navBar-container-width-size' : | ||
| navBarLoc ==='top' ? 'tmplit-navBar-container-top tmplit-navBar-container-height-size' : | ||
| navBarLoc ==='bottom' ? 'tmplit-navBar-container-bottom tmplit-navBar-container-height-size' : | ||
| ${navBarLoc === 'left' ? 'tmplit-navBar-container-left tmplit-navBar-container-width-size' : |
There was a problem hiding this comment.
These lines are my auto-formatter's doing, sorry.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This a proof of concept / alternative strategy for Sanh's project, for learning and discussion purposes.
This demo shows how to change which content goes into a slot dynamically, by changing the slot attribute's value on various content fed into the component.
Content is put into the component, representing tabbed content. These divs are marked with the attribute/value
slot="list". Selecting on this yields a list of pages to make navigation for.The component's template has a content slot set aside for the active page (
slot="content"). When the buttons for various pages are selected, that then reassigns the slot attributes for the tabbed areas.This concept is based on MDN Web Components example "slotchange" https://github.com/mdn/web-components-examples/blob/main/slotchange/main.js
Why
Exploring other ways to "swap" what content goes into a given slot.