Feature/material de#tegration #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9190d82.
|
As a standard, would you say that all new tmplits are required to support material themes? |
|
Yes I think so. Specifically colors should have material tokens and icons should be material icons. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This utilizes css tokens to generalize the css of tmplits. This is compatible with themes created with material design theme builder (https://m3.material.io/theme-builder#/custom). Tmplit classes also remove the need for bootstrap. Material design symbols were used in the place of glyphicons.
List of tmplits that were modified:
Button
Led
CheckBox
Numeric
Text
ValueUpDown
Slider
MultiSelect
DirectoryBrowserWindow
Screenshot:
The above screenshot shows material-design-theme-blue without bootstrap.
Why
This gives a standard for how to modify the css of tmplits. It also allows for easy theming of HMIs. Bootstrap is annoying and no one likes it.