Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add native marshmallow.fields.Enum suport #225

Closed
uvsmtid opened this issue Dec 22, 2022 · 1 comment
Closed

Add native marshmallow.fields.Enum suport #225

uvsmtid opened this issue Dec 22, 2022 · 1 comment

Comments

@uvsmtid
Copy link

uvsmtid commented Dec 22, 2022

Enum support was added by marshmallow v3.18.0:
marshmallow-code/marshmallow@fa0ee03

EnumField from marshmallow-enum becomes unnecessary:
justanr/marshmallow_enum#51

In fact, native support is necessary to generate OAS spec from marshmallow specs using apispec.
This line does not support EnumField from marshmallow-enum, it wants Enum from marshmallow:
https://github.com/marshmallow-code/apispec/blob/bd0d12f7b932369f718d1b222a68f1ddff399953/src/apispec/ext/marshmallow/field_converter.py#L512

Suporting Enum makes all pieces work togeter.

@dairiki
Copy link
Collaborator

dairiki commented Jan 9, 2023

Done via #227. Released, just now, in marshmallow-dataclass 8.5.11.

@dairiki dairiki closed this as completed Jan 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants