-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace marshmallow-enum with native marshmallow.fields.Enum #227
Conversation
The CI test is failing under python 3.6. Support for python 3.6 was dropped in Two options (perhaps there are others) appear to be:
|
Python 3.6 reached its end of life over a year ago now. I think it would make sense to drop support for it. |
In the interest of keeping this diff self-contained, I'll just add the extra code to keep python 3.6 support as you mentioned. I can open another PR to discuss dropping 3.6 support as well if we like. |
I do not disagree, however, the last time this came up, @lovasoa wanted to maintain 3.6 support, citing the number of weekly downloads. Since then, download numbers have dropped a bit, but not substantially. One option might be to bump our minor version number, dropping support for py 3.6 in the new version, and maintain two branches (an 8.5.x that supports py3.6, and an 8.6.x which does not). But, as long as it's not too painful to maintain 3.6 support in the current codebase, it's probably cleaner and less work just to do so. |
@otonnesen Would it be worthwhile (and actually work) to make the E.g., in setup.py: EXTRAS_REQUIRE = {
"enum": [
"marshmallow-enum; python_version<'3.7'",
"marshmallow>=3.18; python_version>='3.7'",
],
...
} |
Never mind. I see you just did that! 😆 |
Yeah just tested on 3.6 and 3.10 and it does appear to work as I'd expect |
Will wait for further comments for a couple of days before merging, but LGTM. Thank you @otonnesen! |
Good for me! |
Released, just now, in 8.5.11. Thank you, @otonnesen! |
Addresses #225