Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

V2023 02 24+php8 corrections #287

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

ternite
Copy link
Contributor

@ternite ternite commented Mar 2, 2023

This pull request removes a lot of warning that still arose when I created ODT documents in my specific environment.

As of now, all warnings I saw were resolved. My use case involves a good bunch of plugins which also need attendance when upgrading to PHP 8. Unfortunately, when correcting some of their warnings, new warnings came up in the ODT plugin. Probably because code was traversed within ODT, now, which was omitted previously.

I can't resolve all plugin issues in all plugins I use, right now, so it may be that I will provide more PHP 8 corrections to the ODT plugin when I went over the rest of the plugins (or ideally, when their maintainers provided a PHP 8 fix update).

/resolves #286

@Klap-in
Copy link
Collaborator

Klap-in commented Mar 2, 2023

Looks good so far, shall wait a bit with merging until you finished your round along the other plugins?

@ternite
Copy link
Contributor Author

ternite commented Mar 2, 2023

Ok. I'll certainly provide fixes when they arise during my code reviews of the other plugins.

I cannot say though, when this will be. It's not the highest priority at the moment, since there is no urgent need to upgrade to PHP 8 in our production environment, yet.

Feel free to merge the pull request, anytime, if you believe it's necessary. I'd create a new separate pull request then.

@Klap-in Klap-in merged commit bbe9b1f into lpaulsen93:master Mar 2, 2023
@Klap-in
Copy link
Collaborator

Klap-in commented Mar 2, 2023

Then I merge it already. Just push more to this branch to continue. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still PHP 8 warnings remaining
2 participants