Add 'Unpacked' Fields and Rows #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for using the FromRow/FromField instances for data coming from outside of libpq - in particular, a replication connection.
lpsmith
reviewed
May 29, 2018
| @@ -49,6 +49,7 @@ import Data.Word (Word, Word16, Word32, | |||
|
|
|||
| import Database.PostgreSQL.Simple.Compat (scientificBuilder, (<>), toByteString) | |||
| import Database.PostgreSQL.Simple.FromField | |||
| import Database.PostgreSQL.Simple.Internal (setTypeOid) | |||
| import Database.PostgreSQL.Simple.Time | |||
There was a problem hiding this comment.
Honestly, I think setTypeOid (and maybe some other things to manipulate the "unpacked" stuff?) should be made part of the public interface.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpacked is probably a bad way of putting it (nothing to do with the pragma...)
This is for using the FromRow/FromField instances for data coming from outside of libpq - in particular, a replication connection. It allows us to build the
FieldandRowwithout involving libpq.