Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Update Node Fetch #183

Open
wants to merge 4 commits into
base: v3.x
Choose a base branch
from

Conversation

Ghislain89
Copy link

This PR updates Node Fetch to 2.6.13, to fix node-fetch/node-fetch#1735 and node-fetch/node-fetch#1765

@drodil
Copy link

drodil commented Aug 2, 2024

Possible to get this merged? Actually there's already 2.7.0 that might be used but I think minimum is .13. Thanks!

@dirkluijk
Copy link

It would be nice to get this merged, since node-fetch@2.7.0 still depends on whatwg-url@5.0.0 that invokes a deprecated punycode Node.js module. So this throws a lot of annoying warnings when running on Node.js 22.x:

(node:22157) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

@jackcobb
Copy link

@lquixada Any update on getting this merged? This library is used by countless other libraries as a dependency and would be nice to get this resolved

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants