Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix sidebar spacing issues #372

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Fix sidebar spacing issues #372

merged 6 commits into from
Oct 22, 2024

Conversation

egenerse
Copy link
Contributor

@egenerse egenerse commented Aug 10, 2024 •
edited
Loading

Checklist

  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes
  • I translated all the newly inserted strings into German and English

Motivation and Context

solves #370

Description

PR for github issue #370

Steps for Testing

  1. Change Diagram Type from the left menu to (Component Diagram or any.)
  2. Review the spacing of the preview items in the sidebar.

Test Coverage

File Branch Line

Screenshots

Before After

Screenshot 2024-08-10 at 19 03 11

Screenshot 2024-08-10 at 18 58 42

Screenshot 2024-08-10 at 19 03 29

Screenshot 2024-08-10 at 18 58 38

@egenerse egenerse self-assigned this Aug 10, 2024
matthiaslehnertum
matthiaslehnertum approved these changes Aug 11, 2024
View reviewed changes
Copy link
Collaborator

@matthiaslehnertum matthiaslehnertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@FelixTJDietrich FelixTJDietrich merged commit bdbf39f into develop Oct 22, 2024
4 checks passed
@FelixTJDietrich FelixTJDietrich deleted the fix--Sidebar-spacing-issues branch October 22, 2024 07:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthiaslehnertum matthiaslehnertum matthiaslehnertum approved these changes

Assignees

@egenerse egenerse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egenerse @matthiaslehnertum @FelixTJDietrich