New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix deprecation for carbon 3 #108

Open

tgabi333 wants to merge 1 commit into lucasdotvin:develop from tgabi333:develop

tgabi333 commented Sep 21, 2024

my laravel config is setup to log deprecations, i got this:

production.WARNING: ErrorException: Implicit conversion from float -1.9990081062193847 to int loses precision 
in /app/vendor/lucasdotvin/laravel-soulbscription/src/Enums/PeriodicityType.php:24

As Carbon documentation says:

diffAsCarbonInterval() and diffIn*() (and floatDiffIn*() for versions < 3 when diffIn*() methods returned integer values,
since Carbon 3, they are deprecated as diffIn*() already return floating number, and integer values from it can easily be
obtained with an explicit cast (int)).


          fix for carbon 3

550f4fb

Author

tgabi333 commented Oct 14, 2024

ping @lucasdotvin

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet