Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs(readme): improve packages table #2674

Closed
wants to merge 5 commits into from
Closed

docs(readme): improve packages table #2674

wants to merge 5 commits into from

Conversation

realguse
Copy link

@realguse realguse commented Dec 7, 2024 •
edited
Loading

What is the purpose of this pull request?

  • Documentation update

Description

Tries to make the packages table in the main README.md more clean and modern.

Before Submitting

@realguse realguse changed the title Improve readme docs: slightly overhaul readme Dec 7, 2024
@github-actions github-actions bot added ⚛️ react package Lucide React Package 💎 vue package Lucide Vue package ⚛️ preact package About the Preact Package 🧳 lucide package About the lucide package 🧣 svelte package About the Svelte package ⚛️ react native package About the React Native package 🪝 solid package About the Solid package 🅰️ angular package About the Angular package 🪨 static package About the static package labels Dec 7, 2024
@realguse realguse marked this pull request as ready for review December 7, 2024 20:00
@realguse realguse marked this pull request as draft December 16, 2024 16:26
@realguse realguse changed the title docs: slightly overhaul readme docs: overhaul readme table Dec 19, 2024
@realguse realguse changed the title docs: overhaul readme table docs: overhaul README table Dec 19, 2024
@realguse realguse closed this Dec 19, 2024
@realguse realguse reopened this Dec 19, 2024
@realguse realguse marked this pull request as ready for review December 19, 2024 20:00
@realguse realguse changed the title docs: overhaul README table docs: improve packages table Dec 19, 2024
ericfennis
ericfennis reviewed Dec 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@jguddas
Copy link
Member

jguddas commented Dec 21, 2024

Can we also change the contrast, having light text on a light background is not very readable?
image

@jguddas
Copy link
Member

jguddas commented Dec 21, 2024

Hi @jguddas, could you expand a bit more on the contrast "problem" (and maybe a possible solution), to make this simpler I'm gonna move the badge-changes to a new pr so i can also update all the other badges simultaneously.

I think we should change the foreground color from white to black.

@realguse realguse mentioned this pull request Dec 21, 2024
Closed
3 tasks
@realguse realguse changed the title docs: improve packages table docs(readme): improve packages table Jan 23, 2025
@realguse realguse closed this Jan 25, 2025
@realguse realguse deleted the improve-readme branch January 25, 2025 23:28
@realguse realguse mentioned this pull request Jan 25, 2025
Open
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ericfennis ericfennis ericfennis left review comments

Assignees
No one assigned
Labels
🅰️ angular package About the Angular package 🧳 lucide package About the lucide package ⚛️ preact package About the Preact Package ⚛️ react native package About the React Native package ⚛️ react package Lucide React Package 🪝 solid package About the Solid package 🪨 static package About the static package 🧣 svelte package About the Svelte package 💎 vue package Lucide Vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realguse @jguddas @ericfennis