Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing variable #289

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Add missing variable #289

merged 1 commit into from
Sep 23, 2024

Conversation

amorehead
Copy link
Contributor

@amorehead amorehead commented Sep 23, 2024

  • Adds a missing variable
  • Also, should the following values be True or False by default?
add_atom_ids: bool = False
add_atompair_ids: bool = False
directed_bonds: bool = False

@lucidrains lucidrains merged commit cac8004 into lucidrains:main Sep 23, 2024
11 checks passed
@amorehead amorehead deleted the patch-1 branch September 23, 2024 20:39
@lucidrains
Copy link
Owner

@amorehead probably good to have the network know about the first two, and directed bonds is probably less essential

@lucidrains
Copy link
Owner

these two hyperparameters will have to be correspondingly set (if turned on)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants