Adding new delete_all query method to remove records based on query

[jwoertink]

Fixes #111

Based on how rails works, when you run the delete_all method, it'll return an integer, so it's going to be the last thing you run in your query. You can chain all your wheres like normal though.

[paulcsmith]

I was actually thinking about this yesterday and how “delete_all” is kind of confusing. Is it deleting all or just a subset?

What do you think about “bulk_delete” or “mass_delete” instead? That way it doesn’t mislead people into thinking it’ll just delete everything

[jwoertink]

hmm.... I can see how it may be a bit confusing, though, I do feel like delete_all is pretty standard convention.

Ecto: https://hexdocs.pm/ecto/Ecto.Repo.html#c:delete_all/2
Rails: https://api.rubyonrails.org/classes/ActiveRecord/Relation.html#method-i-delete_all

Though, some do break that
Gorm: http://gorm.io/docs/delete.html#Batch-Delete uses Delete
Laravel: http://gorm.io/docs/delete.html#Batch-Delete uses ->delete()
Granite: https://github.com/amberframework/granite/blob/c4bc435fc9a24a132ff349367ba2b324d22d8948/docs/crud.md#delete not sure if they have a delete based on WHERE query, but maybe clear?
Django: https://docs.djangoproject.com/en/dev/ref/class-based-views/#deleteview also uses delete...

so maybe we just call it delete?

[paulcsmith]

Good call. I think delete makes sense. Other orms use it. It’s what the SQL call uses. I like it!

[paulcsmith]

Also I think we should add delete_all and do a compile time raise that tells people to use delete.

That way if people use it they’ll know what to do

[paulcsmith]

Feel free to merge nice those last bits are addressed