Fix macro string interpolation #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into this when upgrading to lucky 0.17. Not yet having made the necessary changes switching forms to operations, I got the unwieldly ``` Error: undefined macro variable 'type' ``` This is due to mistakenly using normal string interpolation where we instead want the macro argument to be interpolated into the error message. This then shows the proper error message ``` Error: BaseForm has been renamed to SaveOperation. Please inherit from Post::SaveOperation. ```
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this when upgrading to lucky 0.17. Not yet having made the necessary changes switching forms to operations, I got the unwieldly
This is due to mistakenly using normal string interpolation where we instead want the macro argument to be interpolated into the error message. This then shows the proper error message