Log failed queries #326
Merged
Log failed queries #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcsmith
force-pushed
the
pcs/log-failed-queries
branch
3 times, most recently
from
d5ccd08 to
993681e
Compare
jwoertink
reviewed
Mar 16, 2020
src/avram/pool_statement_logging.cr
Outdated
| @@ -32,5 +47,13 @@ module DB | |||
| Avram.logger.log(level, {query: @query, args: logging_args}) | |||
| end | |||
| end | |||
|
|
|||
| private def log_error(*args_, args : Array? = nil) | |||
| Avram.settings.query_log_level.try do |level| | |||
There was a problem hiding this comment.
Should this be log_failed_log_level?
paulcsmith
force-pushed
the
pcs/log-failed-queries
branch
from
993681e to
e2f47bd
Compare
jwoertink
reviewed
Mar 16, 2020
| @@ -21,6 +21,7 @@ module Avram | |||
| setting logger : Dexter::Logger = Dexter::Logger.new(nil) | |||
| setting query_log_level : ::Logger::Severity? | |||
| setting save_failed_log_level : ::Logger::Severity? = ::Logger::Severity::WARN | |||
| setting query_failed_log_level : ::Logger::Severity? = ::Logger::Severity::ERROR | |||
paulcsmith
force-pushed
the
pcs/log-failed-queries
branch
3 times, most recently
from
16d4d5b to
29a25e9
Compare
paulcsmith
force-pushed
the
pcs/log-failed-queries
branch
from
29a25e9 to
4962a9a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this while working on #322. I wanted to see the failed query.
The downside to this is that if you happen to rescue a
PQ::PQErrorlater in your app the failed query will still be logged. I think this is acceptable though since I can't think of a reason not to.I've added a setting though just in case you don't want to log failed queries