Schema enforcer update #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to new up a validation before we want to use it and avoid the database penalty
This allows users to override and change which validations are included
matthewmcgarvey
commented
Dec 4, 2020
|
|
||
| def initialize(@model_class) | ||
| @database_info = @model_class.database.database_info |
There was a problem hiding this comment.
This could no longer live here because #database_info causes a database query which must happen after the database has been configured. Moving it into the class level of models meant that it is no longer the case.
jwoertink
approved these changes
Dec 8, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #453
Related to #555
In order for views to work with SchemaEnforcer,
EnsureMatchingColumnshas to have a configuration to not check required vs. nilable on columns since all columns are nilable in views. This update also changes how we set up validations for SchemaEnforcer so that tables could have different validations than views and there's a way to add/remove/customize validations