Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Integrating with specs #21

Closed
jwoertink opened this issue Mar 18, 2021 · 0 comments · Fixed by #42
Closed

Integrating with specs #21

jwoertink opened this issue Mar 18, 2021 · 0 comments · Fixed by #42

Comments

@jwoertink
Copy link
Member

Default apps will require the migrations manually https://github.com/luckyframework/lucky_cli/blob/master/src/web_app_skeleton/spec/spec_helper.cr.ecr#L12 and then manually run migrate https://github.com/luckyframework/lucky_cli/blob/master/src/web_app_skeleton/spec/setup/setup_database.cr#L2. When you setup your specs, it doesn't know to run the breeze migrations, and it fails. So this becomes one extra step to requiring the breeze migrations here.

If we integrate breeze in to default apps (most likely), then we will have to update the CLI to include the breeze migrations as well. Maybe we just make it easy with require "breeze/spec_helpers"? 🤔

jwoertink added a commit that referenced this issue May 13, 2021
jwoertink added a commit that referenced this issue May 14, 2021
* Adding new spec helpers file. This makes integrating with your app specs easier. Updated README. Fixes #21

* going back to explicit numbering in the README. It seems to be resetting possibly due to the code blocks between the list items...
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant