Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Have maximum request size by default #1143

Closed
UnsolvedCypher opened this issue May 16, 2020 · 0 comments · Fixed by #1916
Closed

Have maximum request size by default #1143

UnsolvedCypher opened this issue May 16, 2020 · 0 comments · Fixed by #1916
Labels
hacktoberfest Valid Issue for Hacktoberfest

Comments

@UnsolvedCypher
Copy link
Contributor

It would be great to check incoming requests to make sure they are below a certain size. Otherwise, a malicious client could hit the server with a huge request and cause a denial-of-service attack. Perhaps this could be an adjustable value in config/server.cr.
@jwoertink jwoertink added the hacktoberfest Valid Issue for Hacktoberfest label Oct 1, 2021
@jwoertink jwoertink removed the hacktoberfest Valid Issue for Hacktoberfest label Nov 1, 2021
@jwoertink jwoertink added the hacktoberfest Valid Issue for Hacktoberfest label Oct 1, 2022
@jwoertink jwoertink removed the hacktoberfest Valid Issue for Hacktoberfest label Nov 6, 2022
@jwoertink jwoertink added the hacktoberfest Valid Issue for Hacktoberfest label Sep 30, 2024
russ added a commit to russ/lucky that referenced this issue Oct 6, 2024
@russ
Adding a MaximumRequestSizeHandler
6809685 
* Configurable to be on/off. Off by default.
* Configurable to set the maximum request size. Default is 1MB.

Ref luckyframework#1143
@russ russ mentioned this issue Oct 6, 2024
Merged
5 tasks
jwoertink pushed a commit that referenced this issue Oct 9, 2024
@russ
Adding a MaximumRequestSizeHandler (#1916)
ff1bebd 
* Adding a MaximumRequestSizeHandler

* Configurable to be on/off. Off by default.
* Configurable to set the maximum request size. Default is 1MB.

Ref #1143

* Setting the spec max_size to something very small to fix the spec.

* Making max_size an Int64

* Removing the redundant settings in spec helper.

* Linting.

I don't have ameba on my mac...

* Adding docs to the head of the handler file.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
hacktoberfest Valid Issue for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a MaximumRequestSizeHandler russ/lucky
2 participants
@jwoertink @UnsolvedCypher