Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding ability to pass boolean attrs to link helper methods #1032

Merged
merged 1 commit into from
Mar 7, 2020

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1029

Description

You can already use the a() method and pass boolean attrs, but now this PR lets you pass those in the link methods as well.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@paulcsmith paulcsmith merged commit 4bf5dc5 into master Mar 7, 2020
@paulcsmith paulcsmith deleted the bugs/1029 branch March 7, 2020 18:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link helpers should accept array of attrs
2 participants