Added missing deleted? method to cookie jar. #1040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #963
Description
In the guides we make mention of a
cookies.deleted?()
method that never actually existed. I'm not sure where it came from (probably me), but this adds that method in.Deleting cookies is weird because to delete a cookie, you set the value to an empty string, and the expire time to something in the past. It's actually up to the individual browsers to remove that cookie. This
deleted?
method will return true if the cookie is bothexpired? && value.blank?
otherwise it's just false.Side note: in the guides, we also make mention of
session.deleted?(:name)
. I decided to not implement this because if a session key is deleted, then it's justnil
. I'm ok with adding it for consistency in the API, but initially I didn't think it's necessary.Checklist
crystal tool format spec src
./script/setup
./script/test