Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Simplify error styling, add human http status #1114

Merged
merged 3 commits into from
Apr 19, 2020
Merged

Simplify error styling, add human http status #1114

merged 3 commits into from
Apr 19, 2020

Conversation

paulcsmith
Copy link
Member

Screen Shot 2020-04-19 at 3 14 13 PM

Screen Shot 2020-04-19 at 3 14 35 PM

Screen Shot 2020-04-19 at 2 39 17 PM

paulcsmith
paulcsmith commented Apr 19, 2020
View reviewed changes
src/lucky/logger_helpers.cr
case status_code
when 200..399
Copy link
Member Author

@paulcsmith paulcsmith Apr 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most requests should be successful. So rather than distracting with a bold green status, just make it white. That way when a real errors pops up it stands out.

Note: We log halted pipes in yellow so redirect due to incorrect permissions still stands out

@paulcsmith paulcsmith merged commit aa4afad into master Apr 19, 2020
@paulcsmith paulcsmith deleted the pcs/error-formatting branch April 19, 2020 19:21
@edwardloveall edwardloveall mentioned this pull request Apr 30, 2020
Merged
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paulcsmith