Add query param to path even if default value is passed

[matthewmcgarvey]

Purpose

Fixes #1201

When attempting to get a path, if you happened to pass in a value to a query param that matched the default value, it was not added to the resulting url.

Description

This change removes all references to the default value of a param when building a path.

Here is a comparison of the route method output. It is formatted and has comments removed.

Before

def self.route(
  no_default : String,
  has_default : String = "default",
  has_nil_default : String | ::Nil = nil,
  anchor : String? = nil
) : Lucky::RouteHelper
  path = path_from_parts()
  query_params = {} of String => String
  param_is_default_or_nil = has_default == "default"
  unless param_is_default_or_nil
    query_params["has_default"] = has_default.to_s
  end
  param_is_default_or_nil = has_nil_default == nil
  unless param_is_default_or_nil
    query_params["has_nil_default"] = has_nil_default.to_s
  end
  param_is_default_or_nil = no_default == nil
  unless param_is_default_or_nil
    query_params["no_default"] = no_default.to_s
  end

  unless query_params.empty?
    path += "?#{HTTP::Params.encode(query_params)}"
  end

  anchor.try do |value|
    path += "#"
    path += URI.encode_www_form(value)
  end

  Lucky::RouteHelper.new :get, path
end

After

def self.route(
  no_default : String,
  has_default = nil,
  has_nil_default = nil,
  anchor : String? = nil
) : Lucky::RouteHelper
  path = path_from_parts()
  query_params = {} of String => String
  query_params["has_default"] = has_default.to_s unless has_default.nil?
  query_params["has_nil_default"] = has_nil_default.to_s unless has_nil_default.nil?
  query_params["no_default"] = no_default.to_s unless no_default.nil?
  
  unless query_params.empty?
    path += "?#{HTTP::Params.encode(query_params)}"
  end

  anchor.try do |value|
    path += "#"
    path += URI.encode_www_form(value)
  end

  Lucky::RouteHelper.new :get, path
end

Checklist

• - An issue already exists detailing the issue/or feature request that this PR fixes
• - All specs are formatted with crystal tool format spec src
• - Inline documentation has been added and/or updated
• - Lucky builds on docker with ./script/setup
• - All builds and specs pass on docker with ./script/test

[paulcsmith]

Thanks for submitting! These macros are a beast to figure out so am not 100% sure how this is working. Do you think you could leave some comments about what it is doing and what the data looks like?

Also one suggestion to add a spec to make sure the defaults are not included if not given explicitly

[paulcsmith]

Could you add a spec for this that makes sure that the default is not shown if not explicitly given? I'm imagining something like this:

Suggested change

	it "is added to the path even if the value matches default" do
	OptionalParams::Index.path(with_default: "default").should eq "/optional_params?with_default=default"
	end
	it "is added to the path if the value matches default and is explicitly given" do
	OptionalParams::Index.path(with_default: "default").should eq "/optional_params?with_default=default"
	end
	it "is not added to the path if not explicitly given" do
	OptionalParams::Index.path(with_default: "default").should eq "/optional_params"
	end

[paulcsmith]

Looks great! Thank you :D