Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixing action route methods when a prefix exists. #1298

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1281

Description

This PR fixes calling action route methods like SomeAction.route or SomeAction.path to include the prefix when a prefix exists. We were already doing route matching, but missing the route helpers.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink merged commit ac2a21a into master Oct 30, 2020
@jwoertink jwoertink deleted the bugs/1281 branch October 30, 2020 18:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route "Not Found" if using route_prefix
2 participants