Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds <blockquote> and <cite> to Lucky::BaseTags #1317

Merged

Conversation

rmarronnier
Copy link
Contributor

Fixes #1316
Adds <blockquote> and <cite> html tags to Lucky::BaseTags.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@stephendolan stephendolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for keeping the list in alphabetical order 👍

We'll wait for one more approval and then get it merged!

@matthewmcgarvey matthewmcgarvey merged commit b688e5f into luckyframework:master Nov 30, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing macros for some html tags
3 participants