Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Officially deprecating route and nested_route #1510

Merged
merged 1 commit into from
May 28, 2021

Conversation

jwoertink
Copy link
Member

Purpose

Ref: #789

Description

The route and nested_route were extracted in to a separate shard https://github.com/matthewmcgarvey/lucky_legacy_routing. This PR officially makes these macros deprecated, as well as removes all of the references in docs and specs.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

…d_route routing methods. These are available in a shard.
@jwoertink jwoertink merged commit d976793 into master May 28, 2021
@jwoertink jwoertink deleted the remove_dynamic_route_references branch May 28, 2021 23:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants