Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fully support PATCH like PUT and DELETE. #885

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

oneiros
Copy link
Contributor

@oneiros oneiros commented Sep 3, 2019

Purpose

Full support for HTTP PATCH along the lines of PUT and DELETE as described in #884

Description

This adds the missing piece for PATCH to be treated just like PUT and DELETE. It can now be parsed from the special parameter _method that Rails-UJS sets on the specially crafted links (that lucky already generates correctly).

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation status has not gotten worse 😉
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@paulcsmith paulcsmith merged commit a17705f into luckyframework:master Sep 3, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants